Identify localhost/ipaddress in RapporSamples

chrome/browser/metrics/rappor/sampling.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/rappor/sampling.h"
 
 #include "chrome/browser/browser_process.h"
 #include "components/rappor/rappor_service.h"
+#include "net/base/net_util.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "url/gurl.h"
 
 namespace rappor {
 
 std::string GetDomainAndRegistrySampleFromGURL(const GURL& gurl) {
+  if (net::IsLocalhost(gurl.host())) {

[Alexei Svitkine (slow), 2015/02/18 21:22:20]

Nit: No {}'s. Same below.

[Steven Holte, 2015/02/19 23:42:19]

Done.

+    return "localhost";

[Nathan Parker, 2015/02/18 21:56:46]

I think this should go inside the if IsHTTPorHTTPS, so then we know "localhost"
doesn't mean some odd scheme

[Steven Holte, 2015/02/19 23:42:19]

Done.

+  }
+  if (gurl.HostIsIPAddress()) {
+    return "ip_address";
+  }
   if (gurl.SchemeIsHTTPOrHTTPS()) {
     return net::registry_controlled_domains::GetDomainAndRegistry(
         gurl, net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);
   }
   if (gurl.SchemeIsFile())
     return gurl.scheme() + "://";
   return gurl.scheme() + "://" + gurl.host();
 }
 
 void SampleDomainAndRegistryFromGURL(const std::string& metric,
                                      const GURL& gurl) {
   if (!g_browser_process->rappor_service())
     return;
   g_browser_process->rappor_service()->RecordSample(
       metric,
       rappor::ETLD_PLUS_ONE_RAPPOR_TYPE,
       GetDomainAndRegistrySampleFromGURL(gurl));
 }
 
 }  // namespace rappor