Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: sky/engine/tonic/dart_exception_factory.cc

Issue 933843004: Use Dart_EmptyString (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sky/engine/config.h" 5 #include "sky/engine/config.h"
6 #include "sky/engine/tonic/dart_exception_factory.h" 6 #include "sky/engine/tonic/dart_exception_factory.h"
7 7
8 #include "sky/engine/tonic/dart_converter.h" 8 #include "sky/engine/tonic/dart_converter.h"
9 #include "sky/engine/tonic/dart_builtin.h" 9 #include "sky/engine/tonic/dart_builtin.h"
10 #include "sky/engine/wtf/text/StringBuilder.h" 10 #include "sky/engine/wtf/text/StringBuilder.h"
(...skipping 18 matching lines...) Expand all
29 Dart_Handle DartExceptionFactory::CreateException(const String& class_name, 29 Dart_Handle DartExceptionFactory::CreateException(const String& class_name,
30 const String& message) { 30 const String& message) {
31 if (core_library_.is_empty()) { 31 if (core_library_.is_empty()) {
32 Dart_Handle library = DartBuiltin::LookupLibrary("dart:core"); 32 Dart_Handle library = DartBuiltin::LookupLibrary("dart:core");
33 core_library_.Set(dart_state_, library); 33 core_library_.Set(dart_state_, library);
34 } 34 }
35 35
36 Dart_Handle exception_class = Dart_GetType( 36 Dart_Handle exception_class = Dart_GetType(
37 core_library_.value(), StringToDart(dart_state_, class_name), 0, 0); 37 core_library_.value(), StringToDart(dart_state_, class_name), 0, 0);
38 Dart_Handle message_handle = StringToDart(dart_state_, message); 38 Dart_Handle message_handle = StringToDart(dart_state_, message);
39 Dart_Handle empty_string = Dart_NewStringFromCString(""); 39 return Dart_New(exception_class, Dart_EmptyString(), 1, &message_handle);
40 return Dart_New(exception_class, empty_string, 1, &message_handle);
41 } 40 }
42 41
43 } // namespace blink 42 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698