Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 933843003: Add a CQ tester (which will start as experimental) with N5's on L. (Closed)

Created:
5 years, 10 months ago by navabi
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cmp-cc_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Add a CQ tester (which will start as experimental) with N5's on L. The intention is to start one slave as an experimental CQ bot. BUG=451250 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294394

Patch Set 1 #

Patch Set 2 : Change name to have n5 in it. #

Patch Set 3 : Set aside a try host for experimental N5 bot. #

Total comments: 2

Patch Set 4 : Make the CQ bot a rel tester. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M masters/master.tryserver.chromium.linux/master.cfg View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M masters/master.tryserver.chromium.linux/slaves.cfg View 1 2 3 2 chunks +13 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/tester.py View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/android/tester.expected/tryserver_chromium_linux_android_n5_rel_tests_recipe.json View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
navabi
This moves a single try bot host to be used as a experimental 10% CQ ...
5 years, 9 months ago (2015-03-06 01:01:16 UTC) #2
Paweł Hajdan Jr.
LGTM https://codereview.chromium.org/933843003/diff/40001/masters/master.tryserver.chromium.linux/slaves.cfg File masters/master.tryserver.chromium.linux/slaves.cfg (right): https://codereview.chromium.org/933843003/diff/40001/masters/master.tryserver.chromium.linux/slaves.cfg#newcode218 masters/master.tryserver.chromium.linux/slaves.cfg:218: 'builder': 'android_n5_dbg_tests_recipe', IMHO there is no need to ...
5 years, 9 months ago (2015-03-06 10:06:18 UTC) #4
navabi
> My recommendation is _not_ to do this, but I'm fine either way. Pawel, can ...
5 years, 9 months ago (2015-03-10 00:44:56 UTC) #5
Paweł Hajdan Jr.
LGTM https://codereview.chromium.org/933843003/diff/40001/masters/master.tryserver.chromium.linux/slaves.cfg File masters/master.tryserver.chromium.linux/slaves.cfg (right): https://codereview.chromium.org/933843003/diff/40001/masters/master.tryserver.chromium.linux/slaves.cfg#newcode218 masters/master.tryserver.chromium.linux/slaves.cfg:218: 'builder': 'android_n5_dbg_tests_recipe', On 2015/03/06 10:06:18, Paweł Hajdan Jr. ...
5 years, 9 months ago (2015-03-10 07:53:57 UTC) #7
Sergiy Byelozyorov
lgtm
5 years, 9 months ago (2015-03-10 16:20:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933843003/60001
5 years, 9 months ago (2015-03-10 22:12:13 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=294394
5 years, 9 months ago (2015-03-10 22:16:19 UTC) #12
navabi
5 years, 9 months ago (2015-03-20 20:28:28 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1025673003/ by navabi@google.com.

The reason for reverting is: CQ bot did it's job and then we moved everything to
N5's. Now it's time to return this bot to the original CQ fleet..

Powered by Google App Engine
This is Rietveld 408576698