Changed fake callbacks to post tasks asynchronously.

Changed fake callbacks to post tasks asynchronously.

This catches bugs related to parameter lifetime that are not caught when
the Run() method is called directly.  See crbug.com/315624 for an
example.

BUG=chromium:316249
TEST=ran unit tests with and without fix for crbug.com/315624
R=nkostylev@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238512

[Darren Krahn, 2013-11-28 01:14:34]

+bartfab

[bartfab (slow), 2013-11-28 12:31:01]

lgtm

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
File
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
(right):

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc:54:
content::BrowserThread::PostTask(
Nit 1: #include "content/public/browser/browser_thread.h"

Nit 2: You could also use base::MessageLoopProxy::current()->PostTask(), which
removes the need for this code to know which specific browser thread it is
actually running on.

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc:55:
content::BrowserThread::UI, FROM_HERE,
Nit: #include "base/location.h"

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc:56:
base::Bind(callback, status_, value_));
Nit: #include "base/bind.h"

[Nikita (slow), 2013-11-28 12:56:45]

lgtm with Bartosz's nits addressed.

This test now catches previous regression with if fix is reverted, right?

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
File
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
(right):

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc:70:
content::BrowserThread::UI, FROM_HERE,
nit: one parameter per line would be more readable.

[Darren Krahn, 2013-12-03 02:04:10]

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
File
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
(right):

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc:54:
content::BrowserThread::PostTask(
On 2013/11/28 12:31:01, bartfab wrote:
> Nit 1: #include "content/public/browser/browser_thread.h"
> 
> Nit 2: You could also use base::MessageLoopProxy::current()->PostTask(), which
> removes the need for this code to know which specific browser thread it is
> actually running on.

Done (nit 2)

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc:55:
content::BrowserThread::UI, FROM_HERE,
On 2013/11/28 12:31:01, bartfab wrote:
> Nit: #include "base/location.h"

Done.

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc:56:
base::Bind(callback, status_, value_));
On 2013/11/28 12:31:01, bartfab wrote:
> Nit: #include "base/bind.h"

Done.

https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc:70:
content::BrowserThread::UI, FROM_HERE,
On 2013/11/28 12:56:45, Nikita Kostylev wrote:
> nit: one parameter per line would be more readable.

Done.

[Darren Krahn, 2013-12-03 02:04:28]

On 2013/11/28 12:56:45, Nikita Kostylev wrote:
> lgtm with Bartosz's nits addressed.
> 
> This test now catches previous regression with if fix is reverted, right?

Right.
> 
>
https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
> File
>
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/93383002/diff/1/chrome/browser/extensions/api...
>
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc:70:
> content::BrowserThread::UI, FROM_HERE,
> nit: one parameter per line would be more readable.

[commit-bot: I haz the power, 2013-12-03 18:38:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dkrahn@chromium.org/93383002/20001

[commit-bot: I haz the power, 2013-12-03 19:16:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dkrahn@chromium.org/93383002/20001

[commit-bot: I haz the power, 2013-12-03 23:45:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dkrahn@chromium.org/93383002/20001

[commit-bot: I haz the power, 2013-12-04 01:06:49]

Change committed as 238512