Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3110)

Unified Diff: device/bluetooth/bluetooth_adapter_chromeos.h

Issue 933823003: bluetooth: Modify DCHECK to conditionals in several BluetoothAdapterChromeOS methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_adapter_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_adapter_chromeos.h
diff --git a/device/bluetooth/bluetooth_adapter_chromeos.h b/device/bluetooth/bluetooth_adapter_chromeos.h
index 12a88f9bbff9a13e1f526f28013b77773e23e2a0..61e4a3a3da9c3c12e5545a96e13a7a059cb80b00 100644
--- a/device/bluetooth/bluetooth_adapter_chromeos.h
+++ b/device/bluetooth/bluetooth_adapter_chromeos.h
@@ -41,6 +41,13 @@ class BluetoothRemoteGattServiceChromeOS;
// The BluetoothAdapterChromeOS class implements BluetoothAdapter for the
// Chrome OS platform.
+//
+// Methods tolerate a shutdown scenario where BluetoothAdapterChromeOS::Shutdown
+// causes IsPresent to return false just before the dbus system is shutdown but
+// while references to the BluetoothAdapterChromeOS object still exists.
+//
+// When adding methods to this class verify shutdown behavior in
+// BluetoothChromeOSTest, Shutdown.
class DEVICE_BLUETOOTH_EXPORT BluetoothAdapterChromeOS
: public device::BluetoothAdapter,
public chromeos::BluetoothAdapterClient::Observer,
@@ -149,6 +156,11 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAdapterChromeOS
private:
friend class base::DeleteHelper<BluetoothAdapterChromeOS>;
friend class BluetoothChromeOSTest;
+ friend class BluetoothChromeOSTest_Shutdown_Test;
+ friend class BluetoothChromeOSTest_Shutdown_OnStartDiscovery_Test;
+ friend class BluetoothChromeOSTest_Shutdown_OnStartDiscoveryError_Test;
+ friend class BluetoothChromeOSTest_Shutdown_OnStopDiscovery_Test;
+ friend class BluetoothChromeOSTest_Shutdown_OnStopDiscoveryError_Test;
// typedef for callback parameters that are passed to AddDiscoverySession
// and RemoveDiscoverySession. This is used to queue incoming requests while
@@ -212,6 +224,7 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAdapterChromeOS
// sink.
void OnRegisterAudioSink(
const device::BluetoothAdapter::AcquiredCallback& callback,
+ const device::BluetoothAudioSink::ErrorCallback& error_callback,
scoped_refptr<device::BluetoothAudioSink> audio_sink);
// Internal method to obtain a BluetoothPairingChromeOS object for the device
@@ -255,7 +268,8 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAdapterChromeOS
const ErrorCallback& error_callback) override;
// Called by dbus:: on completion of the D-Bus method call to start discovery.
- void OnStartDiscovery(const base::Closure& callback);
+ void OnStartDiscovery(const base::Closure& callback,
+ const ErrorCallback& error_callback);
void OnStartDiscoveryError(const base::Closure& callback,
const ErrorCallback& error_callback,
const std::string& error_name,
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_adapter_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698