content/common/indexed_db/indexed_db_key.cc - Issue 933823002: Avoid large inlined automatic methods in IndexedDB code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/indexed_db/indexed_db_key.cc

Issue 933823002: Avoid large inlined automatic methods in IndexedDB code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One more CONTENT_EXPORT Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/indexed_db/indexed_db_key.cc

diff --git a/content/common/indexed_db/indexed_db_key.cc b/content/common/indexed_db/indexed_db_key.cc

index 4c553ca4bdf500f09c8b6ca99453fbc5cb2966f3..1a3d72ec7edf9d3f6e39c5afbf66e6eebcfa4b22 100644

--- a/content/common/indexed_db/indexed_db_key.cc

+++ b/content/common/indexed_db/indexed_db_key.cc

@@ -92,7 +92,9 @@ IndexedDBKey::IndexedDBKey(const base::string16& string)

size_estimate_(kOverheadSize +

(string.length() * sizeof(base::string16::value_type))) {}

-IndexedDBKey::~IndexedDBKey() {}

+IndexedDBKey::IndexedDBKey(const IndexedDBKey& other) = default;

+IndexedDBKey::~IndexedDBKey() = default;

+IndexedDBKey& IndexedDBKey::operator=(const IndexedDBKey& other) = default;

bool IndexedDBKey::IsValid() const {

if (type_ == WebIDBKeyTypeInvalid || type_ == WebIDBKeyTypeNull)

« no previous file with comments | « content/common/indexed_db/indexed_db_key.h ('k') | content/common/indexed_db/indexed_db_key_path.h » ('j') | no next file with comments »