content/browser/indexed_db/indexed_db_blob_info.cc - Issue 933823002: Avoid large inlined automatic methods in IndexedDB code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_blob_info.cc

Issue 933823002: Avoid large inlined automatic methods in IndexedDB code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/indexed_db_backing_store.cc ('K') | « content/browser/indexed_db/indexed_db_blob_info.h ('k') | content/browser/indexed_db/indexed_db_metadata.h » ('j') | content/browser/indexed_db/indexed_db_metadata.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_blob_info.cc

diff --git a/content/browser/indexed_db/indexed_db_blob_info.cc b/content/browser/indexed_db/indexed_db_blob_info.cc

index e4b1a3a1f12f82fc32337e5fcd8c648876d62366..e26aa0c69ee9b40aec169c01fe10d097093bf34f 100644

--- a/content/browser/indexed_db/indexed_db_blob_info.cc

+++ b/content/browser/indexed_db/indexed_db_blob_info.cc

@@ -49,7 +49,10 @@ IndexedDBBlobInfo::IndexedDBBlobInfo(int64 key,

: is_file_(true), type_(type), size_(-1), file_name_(file_name), key_(key) {

}

-IndexedDBBlobInfo::~IndexedDBBlobInfo() {}

+IndexedDBBlobInfo::IndexedDBBlobInfo(const IndexedDBBlobInfo& other) = default;

+IndexedDBBlobInfo::~IndexedDBBlobInfo() = default;

+IndexedDBBlobInfo& IndexedDBBlobInfo::operator=(

+ const IndexedDBBlobInfo& other) = default;

cmumford 2015/02/17 16:34:50 space between methods.

Daniel Bratell 2015/02/18 13:55:45 Done.

void IndexedDBBlobInfo::set_size(int64 size) {

DCHECK_EQ(-1, size_);