Avoid large inlined automatic methods in IndexedDB code.

content/browser/indexed_db/indexed_db_metadata.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_METADATA_H_
 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_METADATA_H_
 
 #include <map>
 
 #include "base/basictypes.h"
 #include "base/strings/string16.h"
 #include "content/common/indexed_db/indexed_db_key_path.h"
 
 namespace content {
 
 struct IndexedDBIndexMetadata {
   static const int64 kInvalidId = -1;
 
-  IndexedDBIndexMetadata() {}
+  IndexedDBIndexMetadata();
   IndexedDBIndexMetadata(const base::string16& name,
                          int64 id,
                          const IndexedDBKeyPath& key_path,
                          bool unique,
-                         bool multi_entry)
-      : name(name),
-        id(id),
-        key_path(key_path),
-        unique(unique),
-        multi_entry(multi_entry) {}
+                         bool multi_entry);
+  IndexedDBIndexMetadata(const IndexedDBIndexMetadata& other);
+  ~IndexedDBIndexMetadata();

[cmumford, 2015/02/17 16:34:50]

Now that these functions can't be inlined you need to add CONTENT_EXPORT so that
all targets can link.

[Daniel Bratell, 2015/02/18 13:55:45]

Done.

+  IndexedDBIndexMetadata& operator=(const IndexedDBIndexMetadata& other);
+
   base::string16 name;
   int64 id;
   IndexedDBKeyPath key_path;
   bool unique;
   bool multi_entry;
 };
 
 struct CONTENT_EXPORT IndexedDBObjectStoreMetadata {
   typedef std::map<int64, IndexedDBIndexMetadata> IndexMap;
 
   static const int64 kInvalidId = -1;
 
   IndexedDBObjectStoreMetadata();
   IndexedDBObjectStoreMetadata(const base::string16& name,
                                int64 id,
                                const IndexedDBKeyPath& key_path,
                                bool auto_increment,
                                int64 max_index_id);
+  IndexedDBObjectStoreMetadata(const IndexedDBObjectStoreMetadata& other);
   ~IndexedDBObjectStoreMetadata();
+  IndexedDBObjectStoreMetadata& operator=(
+      const IndexedDBObjectStoreMetadata& other);
+
   base::string16 name;
   int64 id;
   IndexedDBKeyPath key_path;
   bool auto_increment;
   int64 max_index_id;
 
   IndexMap indexes;
 };
 
 struct CONTENT_EXPORT IndexedDBDatabaseMetadata {
   // TODO(jsbell): These can probably be collapsed into 0.
   enum {
     NO_INT_VERSION = -1,
     DEFAULT_INT_VERSION = 0
   };
 
   typedef std::map<int64, IndexedDBObjectStoreMetadata> ObjectStoreMap;
 
   IndexedDBDatabaseMetadata();
   IndexedDBDatabaseMetadata(const base::string16& name,
                             int64 id,
                             const base::string16& version,
                             int64 int_version,
                             int64 max_object_store_id);
+  IndexedDBDatabaseMetadata(const IndexedDBDatabaseMetadata& other);
   ~IndexedDBDatabaseMetadata();
+  IndexedDBDatabaseMetadata& operator=(IndexedDBDatabaseMetadata& other);
 
   base::string16 name;
   int64 id;
   base::string16 version;
   int64 int_version;
   int64 max_object_store_id;
 
   ObjectStoreMap object_stores;
 };
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_METADATA_H_