Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: content/browser/indexed_db/indexed_db_backing_store.h

Issue 933823002: Avoid large inlined automatic methods in IndexedDB code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_BACKING_STORE_H_ 5 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_BACKING_STORE_H_
6 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_BACKING_STORE_H_ 6 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_BACKING_STORE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 class WriteDescriptor { 170 class WriteDescriptor {
171 public: 171 public:
172 WriteDescriptor(const GURL& url, 172 WriteDescriptor(const GURL& url,
173 int64_t key, 173 int64_t key,
174 int64_t size, 174 int64_t size,
175 base::Time last_modified); 175 base::Time last_modified);
176 WriteDescriptor(const base::FilePath& path, 176 WriteDescriptor(const base::FilePath& path,
177 int64_t key, 177 int64_t key,
178 int64_t size, 178 int64_t size,
179 base::Time last_modified); 179 base::Time last_modified);
180 WriteDescriptor(const WriteDescriptor& other);
181 ~WriteDescriptor();
182 WriteDescriptor& operator=(const WriteDescriptor& other);
cmumford 2015/02/17 16:34:50 operator= is never called, so you could suppress t
Daniel Bratell 2015/02/18 13:55:44 You might be right (I did notice that some of the
180 183
181 bool is_file() const { return is_file_; } 184 bool is_file() const { return is_file_; }
182 const GURL& url() const { 185 const GURL& url() const {
183 DCHECK(!is_file_); 186 DCHECK(!is_file_);
184 return url_; 187 return url_;
185 } 188 }
186 const base::FilePath& file_path() const { 189 const base::FilePath& file_path() const {
187 DCHECK(is_file_); 190 DCHECK(is_file_);
188 return file_path_; 191 return file_path_;
189 } 192 }
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 // complete. While > 0, temporary journal entries may exist so out-of-band 652 // complete. While > 0, temporary journal entries may exist so out-of-band
650 // journal cleaning must be deferred. 653 // journal cleaning must be deferred.
651 size_t committing_transaction_count_; 654 size_t committing_transaction_count_;
652 655
653 DISALLOW_COPY_AND_ASSIGN(IndexedDBBackingStore); 656 DISALLOW_COPY_AND_ASSIGN(IndexedDBBackingStore);
654 }; 657 };
655 658
656 } // namespace content 659 } // namespace content
657 660
658 #endif // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_BACKING_STORE_H_ 661 #endif // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_BACKING_STORE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698