Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 933813003: Reship classes & object literal extensions (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
CC:
v8-dev, marja
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reship classes & object literal extensions R=arv@chromium.org,marja@chromium.org BUG= Committed: https://crrev.com/5fc2b41ccd2bfdbbdd1f0486da9688443dae6c17 Cr-Commit-Position: refs/heads/master@{#26709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/flag-definitions.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
rossberg
5 years, 10 months ago (2015-02-17 13:47:33 UTC) #1
rossberg
Please check CQ after review.
5 years, 10 months ago (2015-02-17 15:58:30 UTC) #3
marja
s/marja/dslomov/ as reviewer? :)
5 years, 10 months ago (2015-02-17 16:09:32 UTC) #5
Dmitry Lomov (no reviews)
On 2015/02/17 16:09:32, marja wrote: > s/marja/dslomov/ as reviewer? :) lgtm :) arv@ since you ...
5 years, 10 months ago (2015-02-17 17:37:39 UTC) #6
arv (Not doing code reviews)
On 2015/02/17 17:37:39, Dmitry Lomov (chromium) wrote: > On 2015/02/17 16:09:32, marja wrote: > > ...
5 years, 10 months ago (2015-02-17 17:38:31 UTC) #7
rossberg
On 2015/02/17 17:38:31, arv wrote: > I thought we wanted to wait for the super.property ...
5 years, 10 months ago (2015-02-17 18:11:23 UTC) #8
Dmitry Lomov (no reviews)
On 2015/02/17 18:11:23, rossberg wrote: > On 2015/02/17 17:38:31, arv wrote: > > I thought ...
5 years, 10 months ago (2015-02-17 20:10:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933813003/1
5 years, 10 months ago (2015-02-17 20:42:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 21:06:28 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 21:06:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fc2b41ccd2bfdbbdd1f0486da9688443dae6c17
Cr-Commit-Position: refs/heads/master@{#26709}

Powered by Google App Engine
This is Rietveld 408576698