Enable PredictorTabHelper on Android.

Enable PredictorTabHelper on Android.

BUG=459213
Committed: https://crrev.com/e986e1a5ef4b7e063d17924094ed519c612abee9
Cr-Commit-Position: refs/heads/master@{#317281}

[Benoit L, 2015-02-17 13:38:18]

lizeb@chromium.org changed reviewers:
+ cbentzel@chromium.org

[Benoit L, 2015-02-17 13:38:19]

Hello Chris,

Here is the trivial CL enabling PredictorTabHelper on Android.

[cbentzel, 2015-02-17 13:44:03]

cbentzel@chromium.org changed reviewers:
+ pmeenan@chromium.org

[cbentzel, 2015-02-17 13:44:04]

Please add a bug to track this.

+pmeenan who has been doing other preconnect logic recently.

https://codereview.chromium.org/933663003/diff/1/chrome/browser/android/tab_a...
File chrome/browser/android/tab_android.cc (right):

https://codereview.chromium.org/933663003/diff/1/chrome/browser/android/tab_a...
chrome/browser/android/tab_android.cc:21: #include
"chrome/browser/net/predictor.h"
Why is this needed?

https://codereview.chromium.org/933663003/diff/1/chrome/browser/ui/tab_helper...
File chrome/browser/ui/tab_helpers.cc (left):

https://codereview.chromium.org/933663003/diff/1/chrome/browser/ui/tab_helper...
chrome/browser/ui/tab_helpers.cc:47: #include
"chrome/browser/net/predictor_tab_helper.h"
Weird, this was in the OS_ANDROID section.

[Benoit L, 2015-02-17 14:57:47]

https://codereview.chromium.org/933663003/diff/1/chrome/browser/android/tab_a...
File chrome/browser/android/tab_android.cc (right):

https://codereview.chromium.org/933663003/diff/1/chrome/browser/android/tab_a...
chrome/browser/android/tab_android.cc:21: #include
"chrome/browser/net/predictor.h"
On 2015/02/17 13:44:03, cbentzel wrote:
> Why is this needed?

Sorry, a leftover from previous experiments.
Done.

[cbentzel, 2015-02-17 15:42:57]

LGTM, but you are going to need to find appropriate OWNERS

[Benoit L, 2015-02-17 16:10:55]

lizeb@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-02-17 16:16:46]

https://codereview.chromium.org/933663003/diff/20001/chrome/browser/ui/tab_he...
File chrome/browser/ui/tab_helpers.cc (right):

https://codereview.chromium.org/933663003/diff/20001/chrome/browser/ui/tab_he...
chrome/browser/ui/tab_helpers.cc:160:
chrome_browser_net::PredictorTabHelper::CreateForWebContents(web_contents);
Can you put this (and the two previous lines) into some kind of alphabetical
order?

[Benoit L, 2015-02-17 16:37:51]

New patchsets have been uploaded after l-g-t-m from cbentzel@chromium.org

[Benoit L, 2015-02-17 16:38:39]

https://codereview.chromium.org/933663003/diff/20001/chrome/browser/ui/tab_he...
File chrome/browser/ui/tab_helpers.cc (right):

https://codereview.chromium.org/933663003/diff/20001/chrome/browser/ui/tab_he...
chrome/browser/ui/tab_helpers.cc:160:
chrome_browser_net::PredictorTabHelper::CreateForWebContents(web_contents);
On 2015/02/17 16:16:46, Avi wrote:
> Can you put this (and the two previous lines) into some kind of alphabetical
> order?

Done.

[Avi (use Gerrit), 2015-02-17 16:52:14]

lgtm

Thanks!

[Benoit L, 2015-02-19 17:39:28]

New patchsets have been uploaded after l-g-t-m from avi@chromium.org

[Benoit L, 2015-02-20 09:14:22]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2015-02-20 09:15:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/933663003/60001

[commit-bot: I haz the power, 2015-02-20 10:58:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-20 10:58:47]

Patchset 4 (id:??) landed as
https://crrev.com/e986e1a5ef4b7e063d17924094ed519c612abee9
Cr-Commit-Position: refs/heads/master@{#317281}