net/quic/quic_sent_packet_manager_test.cc - Issue 933653003: Enable QUIC's pacing by default on all QUIC connections by setting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_packet_manager_test.cc

Issue 933653003: Enable QUIC's pacing by default on all QUIC connections by setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Fully_qualify_std_names_86267997

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_packet_manager_test.cc

diff --git a/net/quic/quic_sent_packet_manager_test.cc b/net/quic/quic_sent_packet_manager_test.cc

index 66150367b67f7b28452e3381cdac06a18e143e6b..82d45d61e84a1a01604c2f14e298a4168b2ff771 100644

--- a/net/quic/quic_sent_packet_manager_test.cc

+++ b/net/quic/quic_sent_packet_manager_test.cc

@@ -1154,6 +1154,8 @@ TEST_F(QuicSentPacketManagerTest, NewRetransmissionTimeout) {

EXPECT_CALL(*network_change_visitor_, OnCongestionWindowChange());

EXPECT_CALL(*network_change_visitor_, OnRttChange());

EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _, _));

+ EXPECT_CALL(*send_algorithm_, PacingRate())

+ .WillRepeatedly(Return(QuicBandwidth::Zero()));

manager_.SetFromConfig(client_config);

EXPECT_TRUE(QuicSentPacketManagerPeer::GetUseNewRto(&manager_));

@@ -1721,6 +1723,8 @@ TEST_F(QuicSentPacketManagerTest, NegotiateReceiveWindowFromOptions) {

QuicConfig client_config;

QuicConfigPeer::SetReceivedSocketReceiveBuffer(&client_config, 1024);