Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 933653002: Expand the content settings permission string for extensions (Closed)

Created:
5 years, 10 months ago by msramek
Modified:
5 years, 10 months ago
Reviewers:
Mike West, battre
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand the content settings permission string for extensions The content settings API is now much more powerful, and the user should understand that. We added camera, microphone and geolocation to the permission string to warn the user that extensions can now change particularly sensitive settings. BUG=459016 Committed: https://crrev.com/4a2bf8b3cdbb81d49f6db2ed88d3a563bb5c9b24 Cr-Commit-Position: refs/heads/master@{#316493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/permission_warnings.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
msramek
Hello, Dominic: According to our short discussion with Balázs, this should be enough. The string ...
5 years, 10 months ago (2015-02-16 15:58:53 UTC) #2
battre
lgtm
5 years, 10 months ago (2015-02-16 16:10:53 UTC) #3
msramek
Paul, presubmit message listed you as suggested owner for the HTML file. I'll try to ...
5 years, 10 months ago (2015-02-16 16:15:59 UTC) #4
chromium-reviews
huh weird! I think another owner would be preferred :) On Mon, Feb 16, 2015 ...
5 years, 10 months ago (2015-02-16 16:17:27 UTC) #5
msramek
Hi Mike, could you PTAL at the permission string change? (turns out you're also an ...
5 years, 10 months ago (2015-02-16 16:19:57 UTC) #7
Mike West
LGTM.
5 years, 10 months ago (2015-02-16 16:25:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933653002/1
5 years, 10 months ago (2015-02-16 16:28:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 17:15:29 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 17:16:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a2bf8b3cdbb81d49f6db2ed88d3a563bb5c9b24
Cr-Commit-Position: refs/heads/master@{#316493}

Powered by Google App Engine
This is Rietveld 408576698