Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 933603002: Build stack frames for stubs only when needed. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Build stack frames for stubs only when needed. The heuristic is quite naive at the moment (build a frame iff the register allocator needed spill slots), we can improve that later. Committed: https://crrev.com/0914181d97665ff1d34b2ef0d57c41d37f9de124 Cr-Commit-Position: refs/heads/master@{#26664}

Patch Set 1 #

Patch Set 2 : MIPS ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -22 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 4 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 4 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Sven Panne
5 years, 10 months ago (2015-02-16 12:58:07 UTC) #2
titzer
Can you go ahead and do MIPS as well? Should be similar.
5 years, 10 months ago (2015-02-16 12:59:55 UTC) #3
Sven Panne
On 2015/02/16 12:59:55, titzer wrote: > Can you go ahead and do MIPS as well? ...
5 years, 10 months ago (2015-02-16 13:09:17 UTC) #4
titzer
lgtm
5 years, 10 months ago (2015-02-16 13:09:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933603002/20001
5 years, 10 months ago (2015-02-16 13:12:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-16 13:44:56 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 13:45:09 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0914181d97665ff1d34b2ef0d57c41d37f9de124
Cr-Commit-Position: refs/heads/master@{#26664}

Powered by Google App Engine
This is Rietveld 408576698