Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 933553003: Files.app: Analytics tweaks (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
mtomasz, Ben Kwa
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Analytics tweaks 1) Report total errors while reporting import task statistics. 2) Report addView when volume changes. 3) Send hit when history file changes. BUG=420680 TEST=browser_test: FileManagerJsTest.* Committed: https://crrev.com/2df221e4be8e76b2c0b9ba4db79eb358605430ff Cr-Commit-Position: refs/heads/master@{#317076}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M ui/file_manager/file_manager/background/js/media_import_handler.js View 3 chunks +6 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/common/js/metrics_events.js View 1 chunk +4 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 chunks +15 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Steve McKay
5 years, 10 months ago (2015-02-19 02:02:23 UTC) #2
mtomasz
CL title missing. lgtm.
5 years, 10 months ago (2015-02-19 02:49:26 UTC) #3
Steve McKay
Ben. I'll be traveling today. Please feel free to flip the commit bit if you're ...
5 years, 10 months ago (2015-02-19 14:59:54 UTC) #4
Ben Kwa
lgtm
5 years, 10 months ago (2015-02-19 17:43:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933553003/20001
5 years, 10 months ago (2015-02-19 17:44:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 18:07:23 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 18:08:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2df221e4be8e76b2c0b9ba4db79eb358605430ff
Cr-Commit-Position: refs/heads/master@{#317076}

Powered by Google App Engine
This is Rietveld 408576698