Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 933523007: zlib/pdf: remove HaveFlate(), depend on preprocessor defines (Closed)

Created:
5 years, 10 months ago by hal.canary
Modified:
5 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

zlib/pdf: remove HaveFlate(), depend on preprocessor defines Committed: https://skia.googlesource.com/skia/+/91d1d621de03faa41528ba2581d172f3a41104ff

Patch Set 1 #

Total comments: 4

Patch Set 2 : 2015-02-17 (Tuesday) 17:35:15 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -47 lines) Patch
M experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/skflate.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFlate.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/core/SkFlate.cpp View 2 chunks +3 lines, -13 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M src/pdf/SkPDFStream.cpp View 3 chunks +14 lines, -3 lines 0 comments Download
M tests/FlateTest.cpp View 2 chunks +10 lines, -12 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hal.canary
ptal
5 years, 10 months ago (2015-02-17 21:59:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933523007/1
5 years, 10 months ago (2015-02-17 22:00:39 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-17 22:00:40 UTC) #5
mtklein
lgtm, just nits https://codereview.chromium.org/933523007/diff/1/experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp File experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp (right): https://codereview.chromium.org/933523007/diff/1/experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp#newcode25 experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp:25: #ifdef SK_NO_FLATE Just remove this? The ...
5 years, 10 months ago (2015-02-17 22:15:15 UTC) #7
hal.canary
https://codereview.chromium.org/933523007/diff/1/experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp File experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp (right): https://codereview.chromium.org/933523007/diff/1/experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp#newcode25 experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp:25: #ifdef SK_NO_FLATE On 2015/02/17 22:15:15, mtklein wrote: > Just ...
5 years, 10 months ago (2015-02-17 22:35:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933523007/20001
5 years, 10 months ago (2015-02-17 22:36:49 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:43:11 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/91d1d621de03faa41528ba2581d172f3a41104ff

Powered by Google App Engine
This is Rietveld 408576698