Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 933523004: Add TypeChecking=Unrestricted to Speech API interfaces (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
haraken, dmazzoni, Mike West
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add TypeChecking=Unrestricted to Speech API interfaces Affects: SpeechSynthesisUtterance.{volume,rate,pitch} SpeechGrammarList.addFrom*(..., optional float weight) SpeechGrammar.weight BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M LayoutTests/fast/speech/scripted/speechgrammar-basics.html View 2 chunks +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/speech/scripted/speechgrammar-basics-expected.txt View 2 chunks +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/speechsynthesis/speech-synthesis-utterance-basics.html View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/modules/speech/SpeechGrammar.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechGrammarList.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
fs
Hard to find specific reviewers for this - dmazzoni seems to be the one to ...
5 years, 10 months ago (2015-02-17 16:05:59 UTC) #2
dmazzoni
lgtm Note that I'm only an author of the synthesis code, not the recognition code ...
5 years, 10 months ago (2015-02-17 16:12:04 UTC) #3
fs
On 2015/02/17 16:12:04, dmazzoni wrote: > lgtm > > Note that I'm only an author ...
5 years, 10 months ago (2015-02-17 16:17:46 UTC) #4
Mike West
LGTM.
5 years, 10 months ago (2015-02-17 16:22:06 UTC) #5
fs
On 2015/02/17 16:22:06, Mike West wrote: > LGTM. Thanks Mike!
5 years, 10 months ago (2015-02-17 16:24:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933523004/1
5 years, 10 months ago (2015-02-17 16:26:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190335
5 years, 10 months ago (2015-02-17 16:29:10 UTC) #9
haraken
5 years, 10 months ago (2015-02-17 23:12:11 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698