Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1614)

Issue 933523003: Fix branch test for merge script. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix branch test for merge script. Failing calls to show-ref cause an exception in python. BUG=chromium:451975 TBR=tandrii@chromium.org NOTRY=true LOG=n TEST=./script_test.py Committed: https://crrev.com/b8ade81ab5b2e8d82d81cd8cb46f2e196e9654b0 Cr-Commit-Position: refs/heads/master@{#26684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M tools/release/common_includes.py View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 10 months ago (2015-02-17 11:39:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933523003/1
5 years, 10 months ago (2015-02-17 11:39:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 11:40:09 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b8ade81ab5b2e8d82d81cd8cb46f2e196e9654b0 Cr-Commit-Position: refs/heads/master@{#26684}
5 years, 10 months ago (2015-02-17 11:40:28 UTC) #6
tandrii(chromium)
5 years, 10 months ago (2015-02-17 11:45:49 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698