Always load signin profile on Chrome OS startup.

chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This test creates a safebrowsing service using test safebrowsing database
 // and a test protocol manager. It is used to test logics in safebrowsing
 // service.
 
 #include <algorithm>
 
@@ skipping 30 matching lines @@
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/web_contents.h"
 #include "net/cookies/cookie_store.h"
 #include "sql/connection.h"
 #include "sql/statement.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
 #if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chromeos/chromeos_switches.h"
 #endif
 
 using content::BrowserThread;
 using content::InterstitialPage;
 using content::WebContents;
 using ::testing::_;
 using ::testing::Mock;
 using ::testing::StrictMock;
 
@@ skipping 959 matching lines @@
 
   // Change one of the prefs. SBS should keep running.
   pref_service->SetBoolean(prefs::kSafeBrowsingEnabled, false);
   WaitForIOThread();
   EXPECT_TRUE(sb_service->enabled());
   EXPECT_TRUE(csd_service->enabled());
 
   // Change the other pref. SBS should stop now.
   pref_service2->SetBoolean(prefs::kSafeBrowsingEnabled, false);
   WaitForIOThread();
+#if defined(OS_CHROMEOS)
+  // On Chrome OS we should disable safe browsing for signin profile.

[mattm, 2015/02/17 23:13:06]

Comment seemed a little confusing.
Is "On Chrome OS we also need to disable safe browsing for signin profile."
correct?

More importantly though, this is worrisome. Does it mean on real devices
safebrowsing service will always be enabled, even if the user has disabled
safebrowsing option on their profile(s)? (Would lead to wasting bandwidth
updating the safebrowsing lists when nothing is actually going to use them.)

[Ivan Podogov, 2015/02/18 09:03:30]

Signin profile loads first thing during boot-up anyway. I'm not sure if the safe
browsing is enabled in it by default, but it doesn't really matter, as this
profile is not used for any browsing as such. We may check if that is the case,
but nevertheless, this CL doesn't actually change the existing behavior on
devices.

[Nikita (slow), 2015/02/19 14:48:09]

To clarify what Ivan said, signin profile is in fact used for some limited
"browsing" i.e. when Chrome OS user signs in.

I think safebrowsing is probably enabled for it (not sure though).
But as Ivan mentioned this CL doesn't change how things work for production code
in terms of signin profile and safebrowsing.

On Chrome OS fresh boot signin profile always loads. After user signs in it is
still alive (browsing data is cleared though). Things differ if Chrome crashes
and is restarted while inside user session. Then user profile is loaded
synchronously on Chrome startup + now signin profile will load as well. It will
be used on lock screen.

This particular test works with its own profile: pref_service2.

Signin profile is now always created for "session restore after crash" / browser
restart case which happen to be the same that is used for running tests.

Therefore signin profile needs to be marked here so that it doesn't interfere
with tests purposes.

[mattm, 2015/02/24 20:39:06]

Okay, I verified that is the case and filed
https://code.google.com/p/chromium/issues/detail?id=461493 for that issue.
Could you add a TODO "remove this when crbug.com/461493 is fixed"?

[Ivan Podogov, 2015/02/25 11:11:03]

Done.

+  EXPECT_TRUE(sb_service->enabled());
+  EXPECT_TRUE(csd_service->enabled());
+  chromeos::ProfileHelper::GetSigninProfile()
+      ->GetOriginalProfile()
+      ->GetPrefs()
+      ->SetBoolean(prefs::kSafeBrowsingEnabled, false);
+  WaitForIOThread();
+#endif
   EXPECT_FALSE(sb_service->enabled());
   EXPECT_FALSE(csd_service->enabled());
 
   // Turn it back on. SBS comes back.
   pref_service2->SetBoolean(prefs::kSafeBrowsingEnabled, true);
   WaitForIOThread();
   EXPECT_TRUE(sb_service->enabled());
   EXPECT_TRUE(csd_service->enabled());
 
   // Delete the Profile. SBS stops again.
@@ skipping 196 matching lines @@
   content::WindowedNotificationObserver observer(
       chrome::NOTIFICATION_SAFE_BROWSING_UPDATE_COMPLETE,
       content::Source<SafeBrowsingDatabaseManager>(
           sb_service_->database_manager().get()));
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(&SafeBrowsingDatabaseManagerCookieTest::ForceUpdate, this));
   observer.Wait();
 }