src/svg/SkSVGDevice.cpp - Issue 933483002: add Method param to drawTextOnPath, supporting SVG spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/svg/SkSVGDevice.cpp

Issue 933483002: add Method param to drawTextOnPath, supporting SVG spec Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add guard for android Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/svg/SkSVGDevice.cpp

diff --git a/src/svg/SkSVGDevice.cpp b/src/svg/SkSVGDevice.cpp

index 4b9f48983296837c24b6ea9e2838d84215e187d0..2acf6d15bbeb5526e3f26746fe6c382464b0e565 100644

--- a/src/svg/SkSVGDevice.cpp

+++ b/src/svg/SkSVGDevice.cpp

@@ -618,7 +618,8 @@ void SkSVGDevice::drawPosText(const SkDraw& draw, const void* text, size_t len,

}

void SkSVGDevice::drawTextOnPath(const SkDraw&, const void* text, size_t len, const SkPath& path,

- const SkMatrix* matrix, const SkPaint& paint) {

+ const SkMatrix* matrix, SK_SUPPORT_LEGACY_DRAWTEXTONPATH_PARAM

+ const SkPaint& paint) {

SkString pathID = fResourceBucket->addPath();

{