chrome/browser/background/background_contents_service.cc - Issue 933423003: Make BackgroundContentsService start up BackgroundContents with a delay, as for ExtensionHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 933423003: Make BackgroundContentsService start up BackgroundContents with a delay, as for ExtensionHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: edulcni# Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_contents.cc ('k') | chrome/browser/extensions/chrome_extension_host_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_contents_service.cc

diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc

index 34f8446b24925d7d2fe8458ab170ad0fea6dc4fe..9cb64478d585083d666e2589f870d15db6fd1d18 100644

--- a/chrome/browser/background/background_contents_service.cc

+++ b/chrome/browser/background/background_contents_service.cc

@@ -634,10 +634,7 @@ void BackgroundContentsService::LoadBackgroundContents(

std::string(),

NULL);

- // TODO(atwilson): Create RenderViews asynchronously to avoid increasing

- // startup latency (http://crbug.com/47236).

- contents->web_contents()->GetController().LoadURL(

- url, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());

+ contents->CreateRenderViewSoon(url);

}

BackgroundContents* BackgroundContentsService::CreateBackgroundContents(

« no previous file with comments | « chrome/browser/background/background_contents.cc ('k') | chrome/browser/extensions/chrome_extension_host_delegate.h » ('j') | no next file with comments »