extensions/browser/delayed_start_render_host.h - Issue 933423003: Make BackgroundContentsService start up BackgroundContents with a delay, as for ExtensionHosts.

Side by Side Diff: extensions/browser/delayed_start_render_host.h

Issue 933423003: Make BackgroundContentsService start up BackgroundContents with a delay, as for ExtensionHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/background/background_contents_service.cc ('K') | « chrome/browser/background/background_contents_service.cc ('k') | extensions/browser/extension_host.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef EXTENSIONS_BROWSER_DELAYED_START_RENDER_HOST_H_

	6 #define EXTENSIONS_BROWSER_DELAYED_START_RENDER_HOST_H_

	7

	8 namespace extensions {

	9

	10 // A browser component that tracks a renderer. It allows for its renderer

	11 // startup to be delayed, to throttle resource usage upon profile startup.

	12 // To be used with ExtensionHostQueue.

	13 //

	14 // Note that if BackgroundContents and ExtensionHost are unified

	15 // (crbug.com/77790), this interface will be no longer needed.

	16 class DelayedStartRenderHost {
	Yoyo Zhou 2015/02/18 22:53:18 This is not my favoritest name - suggestions welco This is not my favoritest name - suggestions welcome. Devlin 2015/02/18 23:22:12 Even though the DelayedStart part of this is a pre Show quoted text On 2015/02/18 22:53:18, Yoyo Zhou (OOO...2015-02-16) wrote: > This is not my favoritest name - suggestions welcome. Even though the DelayedStart part of this is a pretty central detail of the implementation, I think it actually is still an implementation detail here, and is more suited to a comment on the ExtensionHostQueue (imagine, for instance, if we had a queue that just immediately created everything). So maybe just ExtensionRenderViewCreator? Not sure that's much better... Yoyo Zhou 2015/02/19 02:55:37 I came up with the slightly tautological Extension Show quoted text On 2015/02/18 23:22:12, Devlin wrote: > On 2015/02/18 22:53:18, Yoyo Zhou (OOO...2015-02-16) wrote: > > This is not my favoritest name - suggestions welcome. > > Even though the DelayedStart part of this is a pretty central detail of the > implementation, I think it actually is still an implementation detail here, and > is more suited to a comment on the ExtensionHostQueue (imagine, for instance, if > we had a queue that just immediately created everything). So maybe just > ExtensionRenderViewCreator? Not sure that's much better... I came up with the slightly tautological ExtensionQueueHost. Sadly, the queue is still an implementation detail... I'll keep thinking about it. Devlin 2015/02/19 16:41:43 Also, I think that having ExtensionQueueHost and E Show quoted text On 2015/02/19 02:55:37, Yoyo Zhou (OOO...2015-02-16) wrote: > On 2015/02/18 23:22:12, Devlin wrote: > > On 2015/02/18 22:53:18, Yoyo Zhou (OOO...2015-02-16) wrote: > > > This is not my favoritest name - suggestions welcome. > > > > Even though the DelayedStart part of this is a pretty central detail of the > > implementation, I think it actually is still an implementation detail here, > and > > is more suited to a comment on the ExtensionHostQueue (imagine, for instance, > if > > we had a queue that just immediately created everything). So maybe just > > ExtensionRenderViewCreator? Not sure that's much better... > > I came up with the slightly tautological ExtensionQueueHost. Sadly, the queue is > still an implementation detail... I'll keep thinking about it. Also, I think that having ExtensionQueueHost and ExtensionHostQueue is a little, uh, much. I'll keep thinking, too.
	17 public:

	18 // Called by the ExtensionHostQueue to create the RenderView.

	19 virtual void CreateRenderViewNow() = 0;
	Devlin 2015/02/18 23:22:12 virtual destructor? virtual destructor? Yoyo Zhou 2015/02/19 02:55:37 Done. Show quoted text On 2015/02/18 23:22:12, Devlin wrote: > virtual destructor? Done.
	20 };

	21

	22 } // namespace extensions

	23

	24 #endif // EXTENSIONS_BROWSER_DELAYED_START_RENDER_HOST_H_

OLD	NEW