Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 933413002: Add about:flags control for toggling sync server sandbox (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add about:flags control for toggling sync server sandbox BUG=none Committed: https://crrev.com/e7acd2dbffc9bf26ae63aa8808acdd2b355c5f51 Cr-Commit-Position: refs/heads/master@{#317073}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Evan Stade
https://codereview.chromium.org/933413002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/933413002/diff/1/tools/metrics/histograms/histograms.xml#newcode51674 tools/metrics/histograms/histograms.xml:51674: + <int value="-22544409" label="use-sync-sandbox"/> this is not quite right ...
5 years, 10 months ago (2015-02-18 21:22:03 UTC) #2
Evan Stade
+asvitkine for histograms.xml
5 years, 10 months ago (2015-02-18 21:53:54 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-02-18 22:09:12 UTC) #5
Nicolas Zea
lgtm
5 years, 10 months ago (2015-02-19 01:52:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933413002/20001
5 years, 10 months ago (2015-02-19 17:16:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 17:57:26 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 17:58:26 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e7acd2dbffc9bf26ae63aa8808acdd2b355c5f51
Cr-Commit-Position: refs/heads/master@{#317073}

Powered by Google App Engine
This is Rietveld 408576698