Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 933393003: ASSERT each linkProgram leads to empty cache in ProgramInfoManager. (Closed)

Created:
5 years, 10 months ago by Zhenyao Mo
Modified:
5 years, 10 months ago
Reviewers:
bajones
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ASSERT each linkProgram leads to empty cache in ProgramInfoManager. The current mechanism is to clean all cache, which is very misleading. Everytime we call LinkProgram, we simply delete the Program in the map, getting rid of all cahces, and create a new Program. BUG=429053 TEST=gpu_unittests R=bajones@chromium.org Committed: https://crrev.com/8bd42c20b82615ed26a7791b94e79b55b9d93d19 Cr-Commit-Position: refs/heads/master@{#316937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M gpu/command_buffer/client/program_info_manager.cc View 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Zhenyao Mo
bajones: can you take a look at this one?
5 years, 10 months ago (2015-02-18 21:19:06 UTC) #1
bajones
lgtm
5 years, 10 months ago (2015-02-18 23:35:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933393003/1
5 years, 10 months ago (2015-02-18 23:41:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 00:45:56 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 00:46:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bd42c20b82615ed26a7791b94e79b55b9d93d19
Cr-Commit-Position: refs/heads/master@{#316937}

Powered by Google App Engine
This is Rietveld 408576698