presubmit_canned_checks.py - Issue 933383002: Run dartfmt when invoking git cl format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 933383002: Run dartfmt when invoking git cl format. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Don't error on dart sdk not being installed. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index bd628fb3665c4cc289f22c02c91a5510348eb1c0..f9a20f029a11c552927dc393563944a238a2863e 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -1115,7 +1115,7 @@ def CheckPatchFormatted(input_api, output_api):

code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)

if code == 2:

return [output_api.PresubmitPromptWarning(

- 'The %s directory requires clang-formatting. '

+ 'The %s directory requires source formatting. '

'Please run git cl format %s' %

(input_api.basename(input_api.PresubmitLocalPath()),

input_api.basename(input_api.PresubmitLocalPath())))]

« git_cl.py ('K') | « git_cl.py ('k') | no next file » | no next file with comments »