Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 933353002: Enable documentation for chrome.printerProvider API (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable documentation for chrome.printerProvider API Also, a small update to the documentation in idl file. BUG=408772 TEST=Checked out server2/preview.py Committed: https://crrev.com/f899366965bbfab8be9d19eb0eaff56a2c50acb3 Cr-Commit-Position: refs/heads/master@{#317133}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -21 lines) Patch
A chrome/common/extensions/docs/templates/public/apps/printerProvider.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/extensions/printerProvider.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/printer_provider.idl View 1 2 3 2 chunks +30 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tbarzic
kalman: https://chrome-apps-doc.appspot.com/_patch/933353002/apps/api_index lists printerProvider as a stable API. Any idea what could be wrong there? ...
5 years, 10 months ago (2015-02-19 18:43:32 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 10 months ago (2015-02-19 19:03:49 UTC) #3
not at google - send to devlin
lgtm. The channel thing could be either a lack of channel in the features file, ...
5 years, 10 months ago (2015-02-19 19:48:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933353002/60001
5 years, 10 months ago (2015-02-19 19:58:23 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-19 21:07:03 UTC) #7
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/f899366965bbfab8be9d19eb0eaff56a2c50acb3 Cr-Commit-Position: refs/heads/master@{#317133}
5 years, 10 months ago (2015-02-19 21:07:23 UTC) #8
tbarzic
On 2015/02/19 21:07:23, I haz the power (commit-bot) wrote: > Patchset 4 (id:??) landed as ...
5 years, 10 months ago (2015-02-20 20:45:28 UTC) #9
not at google - send to devlin
5 years, 10 months ago (2015-02-20 20:49:51 UTC) #10
Message was sent while issue was closed.
Alright. Perhaps augment the description with "Since Chrome 42" for now, and I
can look into why the wrong availability is being generated.

Powered by Google App Engine
This is Rietveld 408576698