Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 933333003: Drop unused includes from SVGLayoutStyle.h (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, pdr+renderingwatchlist_chromium.org, rwlbuis, dglazkov+blink, leviw+renderwatch, Dominik Röttsches, dstockwell, Timothy Loh, blink-reviews-rendering, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, eae+blinkwatch, Steve Block, zoltan1, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop unused includes from SVGLayoutStyle.h After pushing most of the ExceptionState-usage out of SVGLength, the construction of SVGLength's no longer need to include ExceptionStatePlaceholder.h CSSValueList.h also isn't needed here, so propagate that to where it is. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/animation/ShadowStyleInterpolation.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/animatable/AnimatableStrokeDasharrayList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyle.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
5 years, 10 months ago (2015-02-19 08:43:41 UTC) #2
rune
lgtm
5 years, 10 months ago (2015-02-19 08:52:00 UTC) #4
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-19 10:57:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933333003/1
5 years, 10 months ago (2015-02-19 12:09:48 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 13:38:48 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190467

Powered by Google App Engine
This is Rietveld 408576698