Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: Source/devtools/front_end/screencast/ScreencastView.js

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added BugId for fixing lazy initialization Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/screencast/ScreencastView.js
diff --git a/Source/devtools/front_end/screencast/ScreencastView.js b/Source/devtools/front_end/screencast/ScreencastView.js
index 4d3749b1b410d6b822773b92815f4c1efa2b4c31..d86b3a18aa9bdfca8368ff4fc52f248069898847 100644
--- a/Source/devtools/front_end/screencast/ScreencastView.js
+++ b/Source/devtools/front_end/screencast/ScreencastView.js
@@ -278,8 +278,20 @@ WebInspector.ScreencastView.prototype = {
}
var text = event.type === "keypress" ? String.fromCharCode(event.charCode) : undefined;
- this._target.inputAgent().dispatchKeyEvent(type, this._modifiersForEvent(event), event.timeStamp / 1000, text, text ? text.toLowerCase() : undefined,
- event.keyIdentifier, event.code, event.keyCode /* windowsVirtualKeyCode */, event.keyCode /* nativeVirtualKeyCode */, false, false, false);
+ this._target.inputAgent().invoke_dispatchKeyEvent({
+ type: type,
+ modifiers: this._modifiersForEvent(event),
+ timestamp: event.timeStamp / 1000,
+ text: text,
+ unmodifiedText: text ? text.toLowerCase() : undefined,
+ keyIdentifier: event.keyIdentifier,
+ code: event.code,
+ key: event.key,
+ windowsVirtualKeyCode: event.keyCode /* windowsVirtualKeyCode */,
dgozman 2015/04/30 09:21:09 nit: you can drop this comment.
+ nativeVirtualKeyCode: event.keyCode /* nativeVirtualKeyCode */,
dgozman 2015/04/30 09:21:09 ditto
+ autoRepeat: false,
+ isKeypad: false,
+ isSystemKey: false});
event.consume();
this._canvasElement.focus();
},

Powered by Google App Engine
This is Rietveld 408576698