Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2793)

Unified Diff: Source/web/tests/WebInputEventConversionTest.cpp

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated comments, and change API name to domKeyEnumFromString Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/WebInputEventConversionTest.cpp
diff --git a/Source/web/tests/WebInputEventConversionTest.cpp b/Source/web/tests/WebInputEventConversionTest.cpp
index 3f5105b114886883886d111444e6dca7e5d56f98..b669303ec6f46fc271c04a3ca2a8350a91040ad4 100644
--- a/Source/web/tests/WebInputEventConversionTest.cpp
+++ b/Source/web/tests/WebInputEventConversionTest.cpp
@@ -57,7 +57,7 @@ namespace {
PassRefPtrWillBeRawPtr<KeyboardEvent> createKeyboardEventWithLocation(KeyboardEvent::KeyLocationCode location)
{
- return KeyboardEvent::create("keydown", true, true, 0, "", "", location, false, false, false, false);
+ return KeyboardEvent::create("keydown", true, true, 0, "", "", "", location, false, false, false, false);
}
int getModifiersForKeyLocationCode(KeyboardEvent::KeyLocationCode location)
@@ -731,7 +731,7 @@ TEST(WebInputEventConversionTest, PinchViewportOffset)
TEST(WebInputEventConversionTest, ElasticOverscroll)
{
- const std::string baseURL("http://www.test6.com/");
+ const std::string baseURL("http://www.test5.com/");
Rick Byers 2015/04/20 19:49:46 Why are you making these baseURL changes?
Habib Virji 2015/04/29 16:00:50 This is rectifying mistake i did in my previous pu
Rick Byers 2015/04/29 17:34:27 Do you mean a previous CL that you landed? If so
Habib Virji 2015/04/30 09:07:24 It was previous CL, related to Keyboard Code. Adde
const std::string fileName("fixed_layout.html");
URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));
@@ -792,7 +792,7 @@ TEST(WebInputEventConversionTest, ElasticOverscroll)
TEST(WebInputEventConversionTest, WebMouseWheelEventBuilder)
{
- const std::string baseURL("http://www.test5.com/");
+ const std::string baseURL("http://www.test6.com/");
const std::string fileName("fixed_layout.html");
URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));
@@ -823,7 +823,7 @@ TEST(WebInputEventConversionTest, WebMouseWheelEventBuilder)
TEST(WebInputEventConversionTest, PlatformWheelEventBuilder)
{
- const std::string baseURL("http://www.test6.com/");
+ const std::string baseURL("http://www.test7.com/");
const std::string fileName("fixed_layout.html");
URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));

Powered by Google App Engine
This is Rietveld 408576698