Source/core/inspector/InspectorInputAgent.cpp - Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorInputAgent.cpp

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated comments, and change API name to domKeyEnumFromString Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/inspector/InspectorInputAgent.h ('k') | Source/devtools/front_end/screencast/ScreencastView.js » ('j') | Source/web/WebInputEventConversion.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorInputAgent.cpp

diff --git a/Source/core/inspector/InspectorInputAgent.cpp b/Source/core/inspector/InspectorInputAgent.cpp

index 1240526413fba786b10ef31d79ab7cdfa6117dc2..2b9beeae56fd7e3daed16a8eea9e22fbcad7e19b 100644

--- a/Source/core/inspector/InspectorInputAgent.cpp

+++ b/Source/core/inspector/InspectorInputAgent.cpp

@@ -100,7 +100,7 @@ InspectorInputAgent::~InspectorInputAgent()

{

}

-void InspectorInputAgent::dispatchKeyEvent(ErrorString* error, const String& type, const int* modifiers, const double* timestamp, const String* text, const String* unmodifiedText, const String* keyIdentifier, const String* code, const int* windowsVirtualKeyCode, const int* nativeVirtualKeyCode, const bool* autoRepeat, const bool* isKeypad, const bool* isSystemKey)

+void InspectorInputAgent::dispatchKeyEvent(ErrorString* error, const String& type, const int* modifiers, const double* timestamp, const String* text, const String* unmodifiedText, const String* keyIdentifier, const String* code, const String* key, const int* windowsVirtualKeyCode, const int* nativeVirtualKeyCode, const bool* autoRepeat, const bool* isKeypad, const bool* isSystemKey)

{

PlatformEvent::Type convertedType;

if (type == "keyDown")

@@ -122,6 +122,7 @@ void InspectorInputAgent::dispatchKeyEvent(ErrorString* error, const String& typ

unmodifiedText ? *unmodifiedText : "",

keyIdentifier ? *keyIdentifier : "",

code ? *code : "",

+ key ? *key : "",

windowsVirtualKeyCode ? *windowsVirtualKeyCode : 0,

nativeVirtualKeyCode ? *nativeVirtualKeyCode : 0,

asBool(autoRepeat),