Add experimental Support for DOM3 KeyboardEvent key value

Source/web/WebInputEventConversion.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 301 matching lines @@
 {
     m_type = toPlatformKeyboardEventType(e.type);
     m_text = String(e.text);
     m_unmodifiedText = String(e.unmodifiedText);
     m_keyIdentifier = String(e.keyIdentifier);
     m_autoRepeat = (e.modifiers & WebInputEvent::IsAutoRepeat);
     m_nativeVirtualKeyCode = e.nativeKeyCode;
     m_isKeypad = (e.modifiers & WebInputEvent::IsKeyPad);
     m_isSystemKey = e.isSystemKey;
     m_code = Platform::current()->domCodeStringFromEnum(e.domCode);
+    m_key = Platform::current()->domKeyStringFromEnum(e.domKey);

[Rick Byers, 2015/04/20 19:49:46]

Wow, I'm surprised we do this every time we create a KeyboardEvent.  I assumed
the point of calling back into the embedder to map between enums and strings was
that we'd do it lazily - only when the application actually requested the
string.  But since this is the existing pattern for m_code, and I don't think
keyboard events are particularly perf sensitive (i.e. don't send them at very
high rates), then keeping it as simple/consistent as possible is certainly best.

[Habib Virji, 2015/04/29 16:00:50]

I agree this is not the best use of the embedded API. I will look into alternate
way of setting this value. Will like to land this CL as things to start working.

[Rick Byers, 2015/04/29 17:34:27]

Yes, please do.  Maybe add a TODO comment here referencing a new bug that you
file saying to explore deferring this call.  This may be a case of premature
optimization though - if you can show (eg. using chrome://tracing) that the cost
is trivial, then it may not be worth changing (depending how hard/ugly it is to
fix).

[Habib Virji, 2015/04/30 09:07:24]

Done.

 
     m_modifiers = toPlatformEventModifiers(e.modifiers);
 
     // FIXME: PlatformKeyboardEvents expect a locational version of the keycode (e.g. VK_LSHIFT
     // instead of VK_SHIFT). This should be changed so the location/keycode are stored separately,
     // as in other places in the code.
     m_windowsVirtualKeyCode = e.windowsKeyCode;
     if (e.windowsKeyCode == VK_SHIFT) {
         if (e.modifiers & WebInputEvent::IsLeft)
             m_windowsVirtualKeyCode = VK_LSHIFT;
@@ skipping 339 matching lines @@
 
     timeStampSeconds = event.timeStamp() / millisPerSecond;
     windowsKeyCode = event.keyCode();
 
     // The platform keyevent does not exist if the event was created using
     // initKeyboardEvent.
     if (!event.keyEvent())
         return;
     nativeKeyCode = event.keyEvent()->nativeVirtualKeyCode();
     domCode = Platform::current()->domEnumFromCodeString(event.keyEvent()->code());
+    domKey = Platform::current()->domKeyEnumFromString(event.keyEvent()->key());
     unsigned numberOfCharacters = std::min(event.keyEvent()->text().length(), static_cast<unsigned>(textLengthCap));
     for (unsigned i = 0; i < numberOfCharacters; ++i) {
         text[i] = event.keyEvent()->text()[i];
         unmodifiedText[i] = event.keyEvent()->unmodifiedText()[i];
     }
     memcpy(keyIdentifier, event.keyIdentifier().ascii().data(), event.keyIdentifier().length());
 }
 
 WebInputEvent::Type toWebKeyboardEventType(PlatformEvent::Type type)
 {
@@ skipping 15 matching lines @@
 {
     type = toWebKeyboardEventType(event.type());
     modifiers = toWebEventModifiers(event.modifiers());
     if (event.isAutoRepeat())
         modifiers |= WebInputEvent::IsAutoRepeat;
     if (event.isKeypad())
         modifiers |= WebInputEvent::IsKeyPad;
     isSystemKey = event.isSystemKey();
     nativeKeyCode = event.nativeVirtualKeyCode();
     domCode = Platform::current()->domEnumFromCodeString(event.code());
+    domKey = Platform::current()->domKeyEnumFromString(event.key());
 
     windowsKeyCode = windowsKeyCodeWithoutLocation(event.windowsVirtualKeyCode());
     modifiers |= locationModifiersFromWindowsKeyCode(event.windowsVirtualKeyCode());
 
     event.text().copyTo(text, 0, textLengthCap);
     event.unmodifiedText().copyTo(unmodifiedText, 0, textLengthCap);
     memcpy(keyIdentifier, event.keyIdentifier().ascii().data(), std::min(static_cast<unsigned>(keyIdentifierLengthCap), event.keyIdentifier().length()));
 }
 
 static WebTouchPoint toWebTouchPoint(const Touch* touch, const LayoutObject* layoutObject, WebTouchPoint::State state)
@@ skipping 84 matching lines @@
     modifiers = getWebInputModifiers(event);
 
     globalX = event.screenX();
     globalY = event.screenY();
     IntPoint localPoint = convertAbsoluteLocationForLayoutObject(event.absoluteLocation(), *layoutObject);
     x = localPoint.x();
     y = localPoint.y();
 }
 
 } // namespace blink