Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 9333001: Include stack trace to error message when constructing a new Error with another Error as argument. (Closed)

Created:
8 years, 10 months ago by Yang
Modified:
8 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Include stack trace to error message when constructing a new Error with another Error as argument. BUG=60240 TEST=cctest/RethrowWrapStackTrace

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -7 lines) Patch
M src/messages.js View 1 chunk +5 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +50 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Not sure whether this makes sense, as this is not really part of the spec. ...
8 years, 10 months ago (2012-02-06 16:43:14 UTC) #1
Yang
On 2012/02/06 16:43:14, Yang wrote: > Not sure whether this makes sense, as this is ...
8 years, 10 months ago (2012-02-06 16:46:16 UTC) #2
Yang
8 years, 10 months ago (2012-02-07 07:12:36 UTC) #3
On 2012/02/06 16:46:16, Yang wrote:
> On 2012/02/06 16:43:14, Yang wrote:
> > Not sure whether this makes sense, as this is not really part of the spec.
> > Basically this changes chaining Errors when rethrown from this
> > 
> > try {
> >   error;
> > } catch (e) {  
> >   throw new Error(e.stack);
> > }
> > 
> > to
> > try {
> >   error;
> > } catch (e) {  
> >   throw new Error(e);
> > }
> > 
> > Also see the thread here:
> > http://code.google.com/p/chromium/issues/detail?id=60240
> 
> Also note that this CL depends on http://codereview.chromium.org/9310122/

On another thought, don't review this. There is no point introducing behavior
that no other browser has, even if it makes sense.

Powered by Google App Engine
This is Rietveld 408576698