Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 933293005: Disable sync for Lightspeed experimentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync doesn't disable for supervised users Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_components_factory_impl.cc
diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc
index bffaf01b96dd7704b11a79a0ab16a06db7c6523c..38ae2c6583e1998d00709e653d0e8b9791839e18 100644
--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc
+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc
@@ -146,6 +146,18 @@ syncer::ModelTypeSet GetDisabledTypesFromCommandLine(
syncer::ModelTypeSet disabled_types;
std::string disabled_types_str =
command_line.GetSwitchValueASCII(switches::kDisableSyncTypes);
+
+ // Disable sync types experimentally to measure impact on startup time.
+ // TODO(mlerman): Remove this after the experiment. crbug.com/454788
+ std::string disable_types_finch =
+ variations::GetVariationParamValue("LightSpeed", "DisableSyncPart");
+ if (!disable_types_finch.empty()) {
+ if (disabled_types_str.empty())
+ disabled_types_str = disable_types_finch;
+ else
+ disabled_types_str += ", " + disable_types_finch;
+ }
+
disabled_types = syncer::ModelTypeSetFromString(disabled_types_str);
return disabled_types;
}

Powered by Google App Engine
This is Rietveld 408576698