Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 933293005: Disable sync for Lightspeed experimentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "build/build_config.h" 6 #include "build/build_config.h"
7 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 7 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
8 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h" 8 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"
9 #include "chrome/browser/dom_distiller/dom_distiller_service_factory.h" 9 #include "chrome/browser/dom_distiller/dom_distiller_service_factory.h"
10 #include "chrome/browser/history/history_service.h" 10 #include "chrome/browser/history/history_service.h"
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 using sync_driver::SharedChangeProcessor; 139 using sync_driver::SharedChangeProcessor;
140 using sync_driver::UIDataTypeController; 140 using sync_driver::UIDataTypeController;
141 141
142 namespace { 142 namespace {
143 143
144 syncer::ModelTypeSet GetDisabledTypesFromCommandLine( 144 syncer::ModelTypeSet GetDisabledTypesFromCommandLine(
145 const base::CommandLine& command_line) { 145 const base::CommandLine& command_line) {
146 syncer::ModelTypeSet disabled_types; 146 syncer::ModelTypeSet disabled_types;
147 std::string disabled_types_str = 147 std::string disabled_types_str =
148 command_line.GetSwitchValueASCII(switches::kDisableSyncTypes); 148 command_line.GetSwitchValueASCII(switches::kDisableSyncTypes);
149
150 // Disable sync types experimentally to measure impact on startup time.
151 // TODO(mlerman): Remove this after the experiment. crbug.com/454788
152 std::string disable_types_finch =
153 variations::GetVariationParamValue("LightSpeed", "DisableSyncPart");
154 if (!disable_types_finch.empty()) {
155 if (disabled_types_str.empty())
156 disabled_types_str = disable_types_finch;
157 else
158 disabled_types_str += ", " + disable_types_finch;
159 }
160
149 disabled_types = syncer::ModelTypeSetFromString(disabled_types_str); 161 disabled_types = syncer::ModelTypeSetFromString(disabled_types_str);
150 return disabled_types; 162 return disabled_types;
151 } 163 }
152 164
153 syncer::ModelTypeSet GetEnabledTypesFromCommandLine( 165 syncer::ModelTypeSet GetEnabledTypesFromCommandLine(
154 const base::CommandLine& command_line) { 166 const base::CommandLine& command_line) {
155 syncer::ModelTypeSet enabled_types; 167 syncer::ModelTypeSet enabled_types;
156 return enabled_types; 168 return enabled_types;
157 } 169 }
158 170
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 new TypedUrlModelAssociator(profile_sync_service, 729 new TypedUrlModelAssociator(profile_sync_service,
718 history_backend, 730 history_backend,
719 error_handler); 731 error_handler);
720 TypedUrlChangeProcessor* change_processor = 732 TypedUrlChangeProcessor* change_processor =
721 new TypedUrlChangeProcessor(profile_, 733 new TypedUrlChangeProcessor(profile_,
722 model_associator, 734 model_associator,
723 history_backend, 735 history_backend,
724 error_handler); 736 error_handler);
725 return SyncComponents(model_associator, change_processor); 737 return SyncComponents(model_associator, change_processor);
726 } 738 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698