[Cronet] Make Cronet buildable on regular Android bots.

components/cronet.gypi

Index: components/cronet.gypi
diff --git a/components/cronet.gypi b/components/cronet.gypi
index e7d68388bc844d5ce8bf99456e00c56593172c71..9a602d4ef7e656330b10d753d5b4dfa588672113 100644
--- a/components/cronet.gypi
+++ b/components/cronet.gypi
@@ -99,78 +99,26 @@
           ],
         },
         {
-          'target_name': 'cronet_static',
-          'type': 'static_library',
-          'dependencies': [
-            '../base/base.gyp:base',
-            '../base/base.gyp:base_i18n',
-            '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
-            '../third_party/icu/icu.gyp:icui18n',
-            '../third_party/icu/icu.gyp:icuuc',
-            'cronet_jni_headers',
-            'cronet_url_request_context_config_list',
-            'cronet_url_request_java',
-            'cronet_version',
-            'metrics',
-            '../net/net.gyp:net',
+          # cronet_static_small target has reduced binary size through disabling
+          # of file and ftp support and using ICU alternatives.
+          'target_name': 'cronet_static_small',
+          'defines': [
+            'USE_ICU_ALTERNATIVES_ON_ANDROID=1',
+            'DISABLE_FILE_SUPPORT=1',
+            'DISABLE_FTP_SUPPORT=1',
           ],
-          'sources': [
-            'cronet/android/chromium_url_request.cc',
-            'cronet/android/chromium_url_request.h',
-            'cronet/android/chromium_url_request_context.cc',
-            'cronet/android/chromium_url_request_context.h',
-            'cronet/android/chromium_url_request_error_list.h',
-            'cronet/android/chromium_url_request_priority_list.h',
-            'cronet/android/cronet_histogram_manager.cc',
-            'cronet/android/cronet_histogram_manager.h',
-            'cronet/android/cronet_library_loader.cc',
-            'cronet/android/cronet_library_loader.h',
-            'cronet/android/cronet_upload_data_stream_adapter.cc',
-            'cronet/android/cronet_upload_data_stream_adapter.h',
-            'cronet/android/cronet_upload_data_stream_delegate.cc',
-            'cronet/android/cronet_upload_data_stream_delegate.h',
-            'cronet/android/cronet_url_request.cc',
-            'cronet/android/cronet_url_request.h',
-            'cronet/android/cronet_url_request_adapter.cc',
-            'cronet/android/cronet_url_request_adapter.h',
-            'cronet/android/cronet_url_request_context_adapter.cc',
-            'cronet/android/cronet_url_request_context_adapter.h',
-            'cronet/android/url_request_adapter.cc',
-            'cronet/android/url_request_adapter.h',
-            'cronet/android/url_request_context_adapter.cc',
-            'cronet/android/url_request_context_adapter.h',
-            'cronet/android/wrapped_channel_upload_element_reader.cc',
-            'cronet/android/wrapped_channel_upload_element_reader.h',
-            'cronet/url_request_context_config.cc',
-            'cronet/url_request_context_config.h',
-            'cronet/url_request_context_config_list.h',
-          ],
-          'cflags': [
-            '-DLOGGING=1',
-            '-fdata-sections',
-            '-ffunction-sections',
-            '-fno-rtti',
-            '-fvisibility=hidden',
-            '-fvisibility-inlines-hidden',
-            '-Wno-sign-promo',
-            '-Wno-missing-field-initializers',
-          ],
-          'ldflags': [
-            '-llog',
-            '-landroid',
-            '-Wl,--gc-sections',
-            '-Wl,--exclude-libs,ALL'
+          'dependencies': [
+            '../net/net.gyp:net_small',
           ],
-          'conditions': [
-            [ 'use_icu_alternatives_on_android == 1', {
-                'dependencies!': [
-                  '../base/base.gyp:base_i18n',
-                  '../third_party/icu/icu.gyp:icui18n',
-                  '../third_party/icu/icu.gyp:icuuc',
-                ]
-              },
-            ],
+          'dependencies!': [
+            '../net/net.gyp:net',
           ],

[mmenke, 2015/03/03 18:03:47]

Instead of an exclusion, could we remove that dep from cronet_static.gypi, and
add it to the cronet_static project?  In general, I think excluding stuff is a
little ugly.

[mef, 2015/03/10 16:50:39]

Done.

+          'includes': [ 'cronet/cronet_static.gypi' ],
+        },
+        {
+          # cronet_static target depends on ICU snd includes file and ftp support.
+          'target_name': 'cronet_static',
+          'includes': [ 'cronet/cronet_static.gypi' ],
         },
         {
           'target_name': 'libcronet',
@@ -179,10 +127,10 @@
             'cronet/android/cronet_jni.cc',
           ],
           'dependencies': [
-            'cronet_static',
+            'cronet_static_small',
             '../base/base.gyp:base',
-            '../net/net.gyp:net',
-            '../url/url.gyp:url_lib',
+            '../net/net.gyp:net_small',
+            '../url/url.gyp:url_lib_use_icu_alternatives_on_android',
           ],
         },
         { # cronet_stub.jar defines HttpUrlRequest interface and provides its
@@ -401,10 +349,6 @@
           },
           'includes': [ '../build/java_apk.gypi' ],
         },
-      ],
-    }],  # OS=="android"
-    ['OS=="android" and use_icu_alternatives_on_android==1', {
-      'targets': [
         {
           'target_name': 'cronet_package',
           'type': 'none',
@@ -533,6 +477,6 @@
           ],
         },
       ],
-    }],  # OS=="android" and use_icu_alternatives_on_android==1
+    }],  # OS=="android"
   ],
 }