Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: net/BUILD.gn

Issue 933293003: [Cronet] Make Cronet buildable on regular Android bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index 76a5cf80ddd19abd68816d1b26439d28c93ee06a..ea82b4c901f945d657a6a72cdbe95083827790a7 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -516,15 +516,16 @@ component("net") {
"//base:i18n",
"//third_party/icu",
]
- sources -= [
- "base/filename_util_icu.cc",
- "base/net_string_util_icu.cc",
- "base/net_util_icu.cc",
- ]
sources += [
"base/net_string_util_icu_alternatives_android.cc",
"base/net_string_util_icu_alternatives_android.h",
]
+ } else {
mmenke 2015/02/27 21:32:43 Shouldn't we be making parallel projects here, too
mef 2015/02/27 22:03:45 Possibly, but we don't have BUILD.gn for Cronet, s
+ sources += [
+ "base/filename_util_icu.cc",
+ "base/net_string_util_icu.cc",
+ "base/net_util_icu.cc",
+ ]
}
}
« no previous file with comments | « components/cronet/cronet_static.gypi ('k') | net/net.gyp » ('j') | net/net.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698