Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 933273002: Revert of Expose camera settings to the extensions. (Closed)

Created:
5 years, 10 months ago by msramek
Modified:
5 years, 10 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Expose camera settings to the extensions. (patchset #3 id:80001 of https://codereview.chromium.org/889893002/) Reason for revert: Setting the camera and microphone default content settings currently cannot be shown in the UI and will not work exactly the way an app developer might expect it to (due to interference with the MEDIASTREAM content setting). Reverting this patch until the UI is ready. Original issue's description: > Expose camera settings to the extensions. > > BUG=453773 > DIFFBASE=880223002 > > Committed: https://crrev.com/2b3079c96f41b136c66d787b3bfa39ee17084cd4 > Cr-Commit-Position: refs/heads/master@{#314319} TBR=mkwst@chromium.org,kalman@chromium.org BUG=453773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_helpers.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/api/content_settings.json View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_settings/standard/test.js View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
msramek
Created Revert of Expose camera settings to the extensions.
5 years, 10 months ago (2015-02-18 11:24:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933273002/1
5 years, 10 months ago (2015-02-18 11:25:26 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-18 11:25:28 UTC) #4
Mike West
LGTM. It's been long enough that notry/nopresubmit is probably a bad idea. Please let this ...
5 years, 10 months ago (2015-02-18 11:42:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933273002/1
5 years, 10 months ago (2015-02-18 11:45:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/59878) ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-18 11:47:59 UTC) #9
msramek
5 years, 10 months ago (2015-02-18 11:52:27 UTC) #10
On 2015/02/18 11:42:47, Mike West wrote:
> LGTM.
> 
> It's been long enough that notry/nopresubmit is probably a bad idea. Please
let
> this run through the CQ as usual.

Good point. And trybots have indeed failed. Automatic revert is impossible here,
as we cannot remove the options from test.js and content_settings_helpers.cc.

Powered by Google App Engine
This is Rietveld 408576698