Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 933253002: Reland https://codereview.chromium.org/929043002/: Add a presubmit check that warns about declaring… (Closed)

Created:
5 years, 10 months ago by Alexander Potapenko
Modified:
5 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland https://codereview.chromium.org/929043002/: Add a presubmit check that warns about declaring Singleton<T> in header files Add a presubmit check that warns about declaring Singleton<T> in header files (except for base/memory/singleton.h) This check is copied from presubmit_canned_checks.py in depot_tools/ with an added exception for base/memory/singleton.h. The corresponding code will be removed from presubmit_canned_checks.py afterwards. BUG=349861 Committed: https://crrev.com/e61efad3b33f83c9bc990cadaae63ba347173ac4 Cr-Commit-Position: refs/heads/master@{#316852}

Patch Set 1 #

Patch Set 2 : Revert chrome/browser/chromeos/login/users/mock_user_manager.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1 line) Patch
M PRESUBMIT.py View 2 chunks +31 lines, -0 lines 0 comments Download
M PRESUBMIT_test.py View 2 chunks +28 lines, -1 line 0 comments Download
M PRESUBMIT_test_mocks.py View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alexander Potapenko
PTAL I've modified MockInputApi.ReadFile() to accept both string file paths and MockAffectedFile objects, like input_api.ReadFile() ...
5 years, 10 months ago (2015-02-18 11:16:15 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 10 months ago (2015-02-18 13:11:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933253002/20001
5 years, 10 months ago (2015-02-18 16:45:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 17:39:51 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 17:41:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e61efad3b33f83c9bc990cadaae63ba347173ac4
Cr-Commit-Position: refs/heads/master@{#316852}

Powered by Google App Engine
This is Rietveld 408576698