Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 933113002: Don't preview autofill/autocomplete until first real mouse move. (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't preview autofill/autocomplete until first real mouse move. BUG=458300 Committed: https://crrev.com/295647dfe774e0630e0efc80d0a35f110bb33d10 Cr-Commit-Position: refs/heads/master@{#317166}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/views/autofill/autofill_popup_base_view.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Evan Stade
+gcasto for review as this will also affect password popups.
5 years, 10 months ago (2015-02-18 03:01:46 UTC) #2
Evan Stade
gcasto is ooo, so +brettw instead
5 years, 10 months ago (2015-02-18 22:32:51 UTC) #4
Evan Stade
On 2015/02/18 22:32:51, Evan Stade wrote: > gcasto is ooo, so +brettw instead ping
5 years, 10 months ago (2015-02-19 18:41:47 UTC) #5
brettw
lgtm
5 years, 10 months ago (2015-02-19 21:33:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933113002/20001
5 years, 10 months ago (2015-02-19 22:15:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 23:27:30 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 23:28:05 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/295647dfe774e0630e0efc80d0a35f110bb33d10
Cr-Commit-Position: refs/heads/master@{#317166}

Powered by Google App Engine
This is Rietveld 408576698