Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: Source/core/layout/MultiColumnFragmentainerGroup.cpp

Issue 933043005: [New Multicolumn] Handle flow thread overflow correctly in flipped writing modes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/MultiColumnFragmentainerGroup.cpp
diff --git a/Source/core/layout/MultiColumnFragmentainerGroup.cpp b/Source/core/layout/MultiColumnFragmentainerGroup.cpp
index 733ac93aeefcbe72475162f4234da25a289f841a..1b3e317cbe681092ab12cab97850b10a1def8d7f 100644
--- a/Source/core/layout/MultiColumnFragmentainerGroup.cpp
+++ b/Source/core/layout/MultiColumnFragmentainerGroup.cpp
@@ -157,7 +157,8 @@ void MultiColumnFragmentainerGroup::collectLayerFragments(LayerFragments& fragme
// Then there's the output from this method - the stuff we put into the list of fragments. The
// fragment.paginationOffset point is the actual visual translation required to get from a
// location in the flow thread to a location in a given column. The fragment.paginationClip
- // rectangle, on the other hand, is in flow thread coordinates.
+ // rectangle, on the other hand, is in flow thread coordinates, but otherwise completely
+ // physical in terms of writing mode.
//
// All other rectangles in this method are sized physically, and the inline direction coordinate
// is physical too, but the block direction coordinate is "logical top". This is the same as
« Source/core/layout/LayoutFlowThread.cpp ('K') | « Source/core/layout/LayoutFlowThread.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698