Source/core/layout/LayoutFlowThread.h - Issue 933043005: [New Multicolumn] Handle flow thread overflow correctly in flipped writing modes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutFlowThread.h

Issue 933043005: [New Multicolumn] Handle flow thread overflow correctly in flipped writing modes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/repaint/paged-with-overflowing-block-rl-expected.txt ('k') | Source/core/layout/LayoutFlowThread.cpp » ('j') | Source/core/layout/LayoutFlowThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutFlowThread.h

diff --git a/Source/core/layout/LayoutFlowThread.h b/Source/core/layout/LayoutFlowThread.h

index d67b50024252e017e41c2d5a637690612c0543eb..f29af04031aaa93cc8bbb59f52bf28e3a5118ffc 100644

--- a/Source/core/layout/LayoutFlowThread.h

+++ b/Source/core/layout/LayoutFlowThread.h

@@ -107,6 +107,9 @@ public:

bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; }

void collectLayerFragments(LayerFragments&, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRect);

+ // Return the visual bounding box based on the supplied flow-thread bounding box. Both

+ // rectangles are completely physical in terms of writing mode.

LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox) const;

LayoutPoint flowThreadPointToVisualPoint(const LayoutPoint& flowThreadPoint) const