Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 932993003: Download the dart sdk into third_party/. (Closed)

Created:
5 years, 10 months ago by Elliot Glaysher
Modified:
5 years, 10 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Download the dart sdk into third_party/. This is meant to be a temporary change. We call wget and unzip from a python script. In a few weeks, this script should be replaced with a call to download_from_google_storage once that script understands archives. BUG=459376 R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/eb78aaf96da844f5cbe3d8c4c22c82d2f520b5db

Patch Set 1 #

Total comments: 3

Patch Set 2 : zra comment #

Patch Set 3 : Remove shell=True. #

Patch Set 4 : Use dev url. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A tools/dart/update.py View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Elliot Glaysher
5 years, 10 months ago (2015-02-17 22:59:12 UTC) #2
zra
https://codereview.chromium.org/932993003/diff/1/tools/dart/update.py File tools/dart/update.py (right): https://codereview.chromium.org/932993003/diff/1/tools/dart/update.py#newcode20 tools/dart/update.py:20: 'stable/release/latest/sdk/dartsdk-linux-x64-release.zip') Even though we'll only be using this for ...
5 years, 10 months ago (2015-02-17 23:06:06 UTC) #3
Elliot Glaysher
https://codereview.chromium.org/932993003/diff/1/tools/dart/update.py File tools/dart/update.py (right): https://codereview.chromium.org/932993003/diff/1/tools/dart/update.py#newcode20 tools/dart/update.py:20: 'stable/release/latest/sdk/dartsdk-linux-x64-release.zip') On 2015/02/17 23:06:06, zra wrote: > Even though ...
5 years, 10 months ago (2015-02-17 23:08:58 UTC) #4
zra
On 2015/02/17 23:08:58, Elliot Glaysher wrote: > https://codereview.chromium.org/932993003/diff/1/tools/dart/update.py > File tools/dart/update.py (right): > > https://codereview.chromium.org/932993003/diff/1/tools/dart/update.py#newcode20 ...
5 years, 10 months ago (2015-02-17 23:13:17 UTC) #5
Elliot Glaysher
Using the url you sent me.
5 years, 10 months ago (2015-02-17 23:32:06 UTC) #6
zra
lgtm
5 years, 10 months ago (2015-02-17 23:33:10 UTC) #7
Elliot Glaysher
5 years, 10 months ago (2015-02-17 23:46:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
eb78aaf96da844f5cbe3d8c4c22c82d2f520b5db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698