Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2415)

Unified Diff: lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp

Issue 932953002: Fix the NaCl bitstream reader to report fatal errors. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Merge with master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/Bitcode/NaCl/Reader/NaClBitCodes.cpp ('k') | lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp
diff --git a/lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp b/lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp
index d5bf4160253ddaeea174cb6bbbb46d4c793ffc7f..761e73345c4c16161901833e581954c93d67c034 100644
--- a/lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp
+++ b/lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp
@@ -86,6 +86,19 @@ NaClBitcodeParser::~NaClBitcodeParser() {
}
}
+bool NaClBitcodeParser::ErrorAt(uint64_t BitPosition,
+ const std::string &Message) {
+ *ErrStream << "Error(" << NaClBitstreamReader::getBitAddress(BitPosition, 1)
+ << "): " << Message << "\n";
+ return true;
+}
+
+void NaClBitcodeParser::FatalAt(uint64_t BitPosition,
+ const std::string &Message) {
+ ErrorAt(BitPosition, Message);
+ report_fatal_error("Unable to continue");
+}
+
bool NaClBitcodeParser::Parse() {
Record.ReadEntry();
« no previous file with comments | « lib/Bitcode/NaCl/Reader/NaClBitCodes.cpp ('k') | lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698