Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: include/llvm/Bitcode/NaCl/NaClObjDumpStream.h

Issue 932953002: Fix the NaCl bitstream reader to report fatal errors. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Fix formatting. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/llvm/Bitcode/NaCl/NaClObjDumpStream.h
diff --git a/include/llvm/Bitcode/NaCl/NaClObjDumpStream.h b/include/llvm/Bitcode/NaCl/NaClObjDumpStream.h
index f75a6c7f9394ee250b84b7844adf211cf492a215..ddf0cfbfb3d9458a8e1193ed3b083c39ce2ccce1 100644
--- a/include/llvm/Bitcode/NaCl/NaClObjDumpStream.h
+++ b/include/llvm/Bitcode/NaCl/NaClObjDumpStream.h
@@ -844,6 +844,7 @@ public:
/// Write a fatal error message to the dump stream, and then
/// stop the executable. If any assembly, comments, or errors have
/// been buffered, they will be printed first.
+ LLVM_ATTRIBUTE_NORETURN
void Fatal(const std::string &Message) {
Fatal(LastKnownBit, Message);
}
@@ -852,11 +853,13 @@ public:
/// stop the executable. If any assembly, comments, or errors have
/// been buffered, they will be printed first. Associates fatal error
/// Message with the given Bit.
+ LLVM_ATTRIBUTE_NORETURN
void Fatal(uint64_t Bit, const std::string &Message);
/// Write a fatal error message to the dump stream, and then
/// stop the executable. If any assembly, comments, or errors have
/// been buffered, they will be printed first, along with the given record.
+ LLVM_ATTRIBUTE_NORETURN
void Fatal(uint64_t Bit,
const llvm::NaClBitcodeRecordData &Record,
const std::string &Message);

Powered by Google App Engine
This is Rietveld 408576698