net/udp/udp_socket_libevent.cc - Issue 932913002: PCHECK when closing UDP sockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/udp/udp_socket_libevent.cc

Issue 932913002: PCHECK when closing UDP sockets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/udp/udp_socket_libevent.cc

diff --git a/net/udp/udp_socket_libevent.cc b/net/udp/udp_socket_libevent.cc

index a36c59b4d64c37a459857c55be34803f04ecbcb0..6fdb94e5eb15e69de304145860163de27489388e 100644

--- a/net/udp/udp_socket_libevent.cc

+++ b/net/udp/udp_socket_libevent.cc

@@ -126,8 +126,7 @@ void UDPSocketLibevent::Close() {

ok = write_socket_watcher_.StopWatchingFileDescriptor();

DCHECK(ok);

- if (IGNORE_EINTR(close(socket_)) < 0)

- PLOG(ERROR) << "close";

+ PCHECK(0 == IGNORE_EINTR(close(socket_)));

socket_ = kInvalidSocket;

addr_family_ = 0;

« no previous file with comments | « no previous file | no next file » | no next file with comments »