Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 932913002: PCHECK when closing UDP sockets (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PCHECK when closing UDP sockets With this change failure to close UDP socket will crash the process. This will help to debug bug 452121, but is also necessary to avoid leaking file descriptors. BUG=452121 Committed: https://crrev.com/fa5f41608e6deac84fe35519d402e3f3e6e82d36 Cr-Commit-Position: refs/heads/master@{#316668}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M net/udp/udp_socket_libevent.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
Per Ricardo's suggestion in https://codereview.chromium.org/914853002/ .
5 years, 10 months ago (2015-02-17 20:00:35 UTC) #2
rvargas (doing something else)
lgtm
5 years, 10 months ago (2015-02-17 20:10:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932913002/20001
5 years, 10 months ago (2015-02-17 20:17:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 22:15:16 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:15:47 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa5f41608e6deac84fe35519d402e3f3e6e82d36
Cr-Commit-Position: refs/heads/master@{#316668}

Powered by Google App Engine
This is Rietveld 408576698