Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 932833002: [strong] Deprecate delete (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
Reviewers:
marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Quoting hell #

Patch Set 3 : Rebase & merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -11 lines) Patch
M src/messages.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/preparser.h View 1 chunk +11 lines, -6 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 2 chunks +11 lines, -1 line 0 comments Download
A test/mjsunit/strong/delete.js View 1 chunk +11 lines, -0 lines 0 comments Download
M test/mjsunit/strong/equality.js View 1 chunk +0 lines, -4 lines 0 comments Download
A test/mjsunit/strong/use-strong.js View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
rossberg
5 years, 10 months ago (2015-02-17 13:33:27 UTC) #1
marja
lgtm
5 years, 10 months ago (2015-02-17 13:51:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932833002/1
5 years, 10 months ago (2015-02-17 13:53:08 UTC) #4
marja
https://codereview.chromium.org/932833002/diff/1/test/mjsunit/strong/use-strong.js File test/mjsunit/strong/use-strong.js (right): https://codereview.chromium.org/932833002/diff/1/test/mjsunit/strong/use-strong.js#newcode1 test/mjsunit/strong/use-strong.js:1: // Copyright 2014 the V8 project authors. All rights ...
5 years, 10 months ago (2015-02-17 13:55:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/3049)
5 years, 10 months ago (2015-02-17 14:09:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932833002/20001
5 years, 10 months ago (2015-02-17 15:17:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932833002/40001
5 years, 10 months ago (2015-02-17 15:57:45 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f55242948ec1aa1c6d65eabb6aab2a9d43343cb5 Cr-Commit-Position: refs/heads/master@{#26698}
5 years, 10 months ago (2015-02-17 16:08:19 UTC) #16
rossberg
5 years, 10 months ago (2015-02-17 16:08:24 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
f55242948ec1aa1c6d65eabb6aab2a9d43343cb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698