Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: test/cctest/test-heap.cc

Issue 932823002: Limit size of first page based on serialized data. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index e80f4f1d06dd86cc00b194f4cd66161ce6be09bb..5136953c1dad2a0e212b1273a5aa0ed446543013 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -4993,3 +4993,20 @@ TEST(PathTracer) {
CcTest::i_isolate()->heap()->TracePathToObject(*o);
}
#endif // DEBUG
+
+
+TEST(FirstPageFitsStartup) {
+ // Test that the first page sizes provided by the default snapshot are large
+ // enough to fit everything right after startup and creating one context.
+ // If this test fails, we are allocating too much aside from deserialization.
+ if (!Snapshot::HaveASnapshotToStartFrom()) return;
+ if (Snapshot::EmbedsScript()) return;
+ CcTest::InitializeVM();
+ LocalContext env;
+ PagedSpaces spaces(CcTest::heap());
+ for (PagedSpace* s = spaces.next(); s != NULL; s = spaces.next()) {
+ int counter = 0;
+ for (PageIterator it(s); it.has_next(); it.next()) counter++;
+ CHECK_LE(counter, 1);
+ }
+}
« src/serialize.h ('K') | « src/snapshot-common.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698