Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 932823002: Limit size of first page based on serialized data. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Limit size of first page based on serialized data. R=hpayer@chromium.org BUG=chromium:453111 LOG=Y Committed: https://crrev.com/afb2706103439e842a5fc0d7aae1e1cdca39474a Cr-Commit-Position: refs/heads/master@{#26764}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Patch Set 3 : fix test case #

Patch Set 4 : fix test failure #

Patch Set 5 : remove printf debugging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -83 lines) Patch
M src/api.cc View 3 chunks +1 line, -56 lines 0 comments Download
M src/full-codegen.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/spaces.cc View 1 2 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/serialize.h View 1 3 chunks +5 lines, -2 lines 0 comments Download
M src/serialize.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/snapshot.h View 3 chunks +17 lines, -3 lines 0 comments Download
M src/snapshot-common.cc View 1 2 4 chunks +78 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-strings.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
Yang
5 years, 10 months ago (2015-02-17 11:48:13 UTC) #1
Yang
On 2015/02/17 11:48:13, Yang wrote: Ping
5 years, 10 months ago (2015-02-18 21:47:41 UTC) #2
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/932823002/diff/1/src/serialize.h File src/serialize.h (right): https://codereview.chromium.org/932823002/diff/1/src/serialize.h#newcode749 src/serialize.h:749: friend class SnapshotData; alphabetic order, please move ObjectSerializer
5 years, 10 months ago (2015-02-19 17:27:39 UTC) #3
Yang
On 2015/02/19 17:27:39, Hannes Payer wrote: > lgtm > > https://codereview.chromium.org/932823002/diff/1/src/serialize.h > File src/serialize.h (right): ...
5 years, 10 months ago (2015-02-20 07:15:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932823002/20001
5 years, 10 months ago (2015-02-20 07:16:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/3141)
5 years, 10 months ago (2015-02-20 07:33:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932823002/40001
5 years, 10 months ago (2015-02-20 08:34:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/3146)
5 years, 10 months ago (2015-02-20 08:49:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932823002/80001
5 years, 10 months ago (2015-02-20 09:13:29 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-20 09:34:05 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 09:34:18 UTC) #17
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/afb2706103439e842a5fc0d7aae1e1cdca39474a
Cr-Commit-Position: refs/heads/master@{#26764}

Powered by Google App Engine
This is Rietveld 408576698