Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.c

Issue 9328024: Merge 7712 - Ensure super instructions are marked during dynamic code modification. (Closed) Base URL: svn://svn.chromium.org/native_client/branches/963/src/native_client/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.c
===================================================================
--- src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.c (revision 7726)
+++ src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.c (working copy)
@@ -755,15 +755,12 @@
if (NULL == iter_new) break;
while (NaClInstIterHasNextInline(iter_old) &&
NaClInstIterHasNextInline(iter_new)) {
- Bool inst_changed;
state->cur_inst_state = NaClInstIterGetStateInline(iter_new);
state->cur_inst = NaClInstStateInst(state->cur_inst_state);
state->cur_inst_vector = NaClInstStateExpVector(state->cur_inst_state);
- inst_changed = NaClValidateInstReplacement(iter_old, iter_new, state);
- if (inst_changed)
- NaClApplyValidators(state, iter_new);
- else
- NaClJumpValidatorRememberIpOnly(state, iter_new);
+ state->cur_inst_state->unchanged =
+ !NaClValidateInstReplacement(iter_old, iter_new, state);
+ NaClApplyValidators(state, iter_new);
if (state->quit) break;
NaClInstIterAdvanceInline(iter_old);
NaClInstIterAdvanceInline(iter_new);
« no previous file with comments | « src/trusted/validator/x86/ncval_reg_sfi/nc_jumps.c ('k') | src/trusted/validator/x86/ncval_seg_sfi/ncdecode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698